Support using system icons with semantics (Linux) #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Right now, we're always converting to an absolute path.
This means that if you're trying to create a notification with the system's
dialog-warningicon, the notification's icon will end-up blank / missing.Why?
Instead of adding extra logic to figure out the absolute path of system icons, I think we should just be able to use the semantic name.
Other possible solutions
If you don't like adding this check to the
pathAbsfunction, I could simply move the check to thenotify_unix.go:17file directly, as to not impact any other platforms.Calling a notification with the icon
dialog-warningBefore PR:
After PR:
Note
I have not tested any other platforms, only linux with KDE plasma