don't cache on asset not found (#2346)

genshinsim · Feb 19, 2025 · 72df55e · 72df55e
1 parent ab67431
commit 72df55e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/internal/services/assets/handler.go b/internal/services/assets/handler.go
@@ -85,6 +85,7 @@ func (s *Server) handleNotFound(w http.ResponseWriter) {
 		w.WriteHeader(http.StatusNotFound)
 		return
 	}
+	w.Header().Set("Cache-Control", "no-cache")
 	w.WriteHeader(http.StatusOK)
 	w.Write(data)
 }

diff --git a/ui/packages/workers/src/preview/handlePreview.ts b/ui/packages/workers/src/preview/handlePreview.ts
@@ -45,9 +45,10 @@ export async function handlePreview(
     );
 
     response = new Response(resp.body, resp);
-    response.headers.set("Cache-Control", "max-age=5184000");
-
-    event.waitUntil(cache.put(cacheKey, response.clone()));
+    if (resp.headers.get('Cache-Control') !== 'no-cache') {
+      response.headers.set('Cache-Control', 'max-age=5184000');
+      event.waitUntil(cache.put(cacheKey, response.clone()));
+    }
   }
 
   return response;