Adopt eslint

.github/workflows/main.yml

@@ -23,14 +23,29 @@ jobs:
 
     steps:
       - uses: actions/checkout@v2
+      - uses: actions/setup-node@v4
+        with:
+          node-version: '22.11.0'
 
       - name: Lint Dockerfiles
         run: |
           wget -O hadolint https://github.com/hadolint/hadolint/releases/download/v2.12.0/hadolint-Linux-x86_64
           mv hadolint /usr/local/bin/hadolint
           chmod +x /usr/local/bin/hadolint
-          ls -la
-          hadolint --config .hadolint.yaml ./Dockerfiles/*
+          hadolint --config .hadolint.yaml Dockerfiles/*
+
+      - name: Lint Dockerfiles
+        run: |
+          wget -O hadolint https://github.com/hadolint/hadolint/releases/download/v2.12.0/hadolint-Linux-x86_64
+          mv hadolint /usr/local/bin/hadolint
+          chmod +x /usr/local/bin/hadolint
+          hadolint --config .hadolint.yaml Dockerfiles/*
+
+      - name: Lint JS
+        run: |
+          cd src/
+          npm i
+          npx eslint .
 
   build:
     if: "!contains(github.event.head_commit.message, 'skip ci')"

src/db.js

@@ -1,5 +1,6 @@
 import pgPromise from "pg-promise"
 import { wipeDB } from "./utils.js"
+import { process } from "node:process"
 
 const pgp = pgPromise({})
 

src/eslint.config.js

@@ -0,0 +1,14 @@
+import globals from "globals";
+import pluginJs from "@eslint/js";
+
+
+/** @type {import('eslint').Linter.Config[]} */
+export default [
+  {languageOptions: { globals: globals.browser }},
+  pluginJs.configs.recommended,
+    {
+        rules: {
+            "no-prototype-builtins": "off"
+        }
+    }
+];

src/index.js

@@ -91,7 +91,7 @@ app.get("/recommendations", async (req, res) => {
     const tagsVal = sanitizeString(checkForBannedWords(req.query, "tags"))
     const limit = parseInt(sanitizeString(checkForBannedWords(req.query, "limit")))
 
-    if (limit === NaN || tagsVal === "") {
+    if (isNaN(limit) || tagsVal === "") {
         res.status(400).json({
             "message": "Invalid request body",
         })
@@ -120,7 +120,7 @@ app.get("/recommendations", async (req, res) => {
                         deploymentURLs.push(deployment[0].url)
                     }
                 }
-            } catch {}
+            } catch {} // eslint-disable-line no-empty
         }
     })