Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add license #36

Merged
merged 7 commits into from
Oct 19, 2022
Merged

Add license #36

merged 7 commits into from
Oct 19, 2022

Conversation

capsulecorplab
Copy link
Collaborator

closes #7

Copy link
Collaborator

@TristanDamron TristanDamron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left you a few comments!

LICENSE.md Show resolved Hide resolved
LICENSE.md Show resolved Hide resolved
@TristanDamron
Copy link
Collaborator

@j-simmons-phd @Ahmad-Mukhtar as contributors to this project prior to us incorporating a license, Sean and I wanted to get your blessings to distribute the geoCML base image under the GPL v2. If you feel super strongly that we shouldn't be using the GPL for this project, let's have a discussion about that over on the GitHub Discussions board! Otherwise, we'd really appreciate if you could respond to this thread with a 'Sounds good to me' or drop an emoji reaction on this comment so we know you're cool with this license. Thank you for contributing your efforts to get us closer towards our first release!

@j-simmons-phd
Copy link
Contributor

@TristanDamron My approach to licensing the KASM image technology has been to follow the originator’s lead on licensing. Given my code is a remix of their code to simplify development of multiple KASM images, I would suggest consulting with the KASM group themselves as well before relicensing to GPL.

Additionally, any GPL’ed code you introduce that could be important in the originating repository would not be able to be merged back in as I will not be changing my code base to GPL. So, my preference, in the interest of facilitating future collaboration and simplifying things with the KASM originators, would be to maintain the MIT license as we did when we built off of KASM code.

@Ahmad-Mukhtar
Copy link
Contributor

Sounds good to me

@TristanDamron
Copy link
Collaborator

@j-simmons-phd I've done some more research into this... Because the MIT license permits sub-licensing, I don't think it's necessary to consult with the Kasm developers for changes you make to their license, (they clearly know this is possible under MIT, otherwise they wouldn't have chosen it for this project). You are correct though in that we cannot relicense the software. What we need to do, then, is amend the original MIT license from Kasm with the conditions I described here: 20a8865#r971050848

For the needs of this project, I am really against using a vanilla MIT license. Without a incorporating a copyleft and upstream clause, this license is antithetical to the reasons the project was started.

cc: @capsulecorplab

@capsulecorplab
Copy link
Collaborator Author

Apologies for taking so long on updating this PR! In the interest of incorporating the GPL v2 license, while also preserving the original verbiage/clauses of the MIT license, I've updated LICENSE.md to include both the contents of the MIT and GPL v2 license as of bf4151e

in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@capsulecorplab We should put the GPL conditions under this line rather than having them at the end of the license.

@TristanDamron TristanDamron merged commit 1c7ef60 into main Oct 19, 2022
@capsulecorplab capsulecorplab deleted the add-license branch November 22, 2022 21:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add MIT license
4 participants