Fix array type #33
Fix array type #33
Conversation
|
Hi! Thanks for the PR. A general objection I have with the PR is that you should try to follow the coding style of the repo and not enforce your own. For example you added semicolons, replaced single quotes with double quotes etc. |
yarn.lock
Outdated
There was a problem hiding this comment.
There are still some changes in the yarn.lock file. Make sure you revert everything
test/array-as-properties/index.ts
Outdated
| } | ||
|
|
||
| interface SquareConfigsInterface { | ||
| squares: SquareConfig[] | ||
| squares: SquareConfig[]; | ||
| logs?: string[]; |
There was a problem hiding this comment.
After adding this you also have to update test/array-as-properties/fixture.json accordingly.
Did you try to run the tests?
There was a problem hiding this comment.
Make sure you fix the issue mentioned here also #33 (comment)
Please remove any change that is not related to the feature.
|
If you don't mind I could push a commit to update the tests. In that case make sure "Allow edits from maintainers" is checked |
|
Yes sure, I checked the option. You can apply the modifications required |
|
For some reason I cannot push to your branch due to permission issues. In any case in order to address this issue we would have to revert most of your changes. It would be easier and cleaner to do it in a new PR. |
If we are having an attributes with an array type, it was shown as "Object[]" without specification of element's type of the array. I just modified the "if" condition to show the type of the elements in case of a Native type. As a result, it will be shown as String[] or Number[] etc.
I hope this modification are useful.
