Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: format date & time renderables #1108

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
+347 −211
Open

feat: format date & time renderables #1108

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
c7faf72
feat: add date-fns pkgs
mikallojjus Mar 3, 2025
aaad10b
feat: format date in date-field component
mikallojjus Mar 3, 2025
6cf8d07
feat: update styles for date-field
mikallojjus Mar 3, 2025
26779fb
feat: add dropdown for time type in editable-entity-page
mikallojjus Mar 3, 2025
b0d7e66
feat: use TripleValueOptions from grc-20-ts
mikallojjus Mar 6, 2025
9c6c6c9
feat: pass options to date field
mikallojjus Mar 6, 2025
0620a1a
feat: adjust change review logic to check for option changes
mikallojjus Mar 6, 2025
b638afb
fix: change span to p for date field's formatted value
mikallojjus Mar 6, 2025
f625c22
fix: option comparison in change calculations
mikallojjus Mar 7, 2025
d43f347
fix: remove unused styles
mikallojjus Mar 7, 2025
bac84c8
fix: omit undefined option values
mikallojjus Mar 8, 2025
3789173
fix: date diff view highlighting
mikallojjus Mar 8, 2025
10c6de6
fix: remove console.log
mikallojjus Mar 10, 2025
afba6f7
fix: add hasFormatChanged to DateTimeDiff
mikallojjus Mar 10, 2025
43599e2
fix: diff view when before or after is null
mikallojjus Mar 10, 2025
596ed6e
fix: hide format when value is empty
mikallojjus Mar 10, 2025
b69ad39
fix: time container adjusting in size when changing format
mikallojjus Mar 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: time container adjusting in size when changing format
  • Loading branch information
@mikallojjus
mikallojjus committed Mar 10, 2025

Verified

This commit was signed with the committer’s verified signature.
schroda schroda
SSH Key Fingerprint: NkAR1cQqUd2tKRv4GHgjvfhbsZtKIEy4m3JjdFM8PM8
Verified
Learn about vigilant mode
commit b69ad3970776485308a82966fec50d21c16b100f
2 changes: 1 addition & 1 deletion apps/web/design-system/editable-fields/date-field.tsx
View file
Original file line number Diff line number Diff line change
@@ -360,7 +360,7 @@ export function DateField(props: DateFieldProps) {
/>
</div>
</div>
<div className="flex items-center">
<div className="flex grow items-center">
<Minus color="grey-02" className="size-4" />
<Spacer width={14} />
<div className="flex items-center gap-1">