Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Arithmetic expression support in Parser #1093

Open
1 of 2 tasks
xzdandy opened this issue Sep 11, 2023 · 2 comments
Open
1 of 2 tasks

Arithmetic expression support in Parser #1093

xzdandy opened this issue Sep 11, 2023 · 2 comments
Labels

Comments

@xzdandy
Copy link
Collaborator

xzdandy commented Sep 11, 2023

Search before asking

  • I have searched the EvaDB issues and found no similar feature requests.

Description

Currently, EvaDB does not have arithmetic expression support in https://github.com/georgia-tech-db/evadb/blob/staging/evadb/parser/lark_visitor/_expressions.py. So expression in projection or predicate with arithmetic operations does not work. Simple query to test:

SELECT 1+2;

Use case

No response

Are you willing to submit a PR?

  • Yes I'd like to help by submitting a PR!
@aayushacharya
Copy link

Hi, may I work on this feature?

@aayushacharya
Copy link

I have added PR #1444 corresponding to this feature. I would love to get feedback if changes need to be made. The supported operations in precedence are:

  1. Multiplication *, Division / and Modulo %
  2. Addition + and Subtraction -

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
Development

No branches or pull requests

2 participants