Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feat : Sqlite Database Handler #1023

Merged
merged 9 commits into from
Sep 1, 2023

Conversation

Chitti-Ankith
Copy link
Contributor

This diff adds extends the database interface to add support for SQLite.

Test Plan : UT

@Chitti-Ankith Chitti-Ankith mentioned this pull request Sep 1, 2023
@xzdandy
Copy link
Collaborator

xzdandy commented Sep 1, 2023

The PR looks good! Thanks for the contribution. Could you fix the linter and unit test?

You can also add Sqlite in the documentation. https://evadb.readthedocs.io/en/latest/source/reference/databases/index.html

@jiashenC For sqlite, we do not need backend server, shall we consider move the test cases outside test_native_exectuor.py so it can run in the PR's circle ci. Or we will leave it to staging and master for consistency.

@jiashenC
Copy link
Member

jiashenC commented Sep 1, 2023

The PR looks good! Thanks for the contribution. Could you fix the linter and unit test?

You can also add Sqlite in the documentation. https://evadb.readthedocs.io/en/latest/source/reference/databases/index.html

@jiashenC For sqlite, we do not need backend server, shall we consider move the test cases outside test_native_exectuor.py so it can run in the PR's circle ci. Or we will leave it to staging and master for consistency.

Yeah. I am fine with either creating a separate docker or doing it inside integration. Any preference @xzdandy?

@xzdandy
Copy link
Collaborator

xzdandy commented Sep 1, 2023

The PR looks good! Thanks for the contribution. Could you fix the linter and unit test?
You can also add Sqlite in the documentation. https://evadb.readthedocs.io/en/latest/source/reference/databases/index.html
@jiashenC For sqlite, we do not need backend server, shall we consider move the test cases outside test_native_exectuor.py so it can run in the PR's circle ci. Or we will leave it to staging and master for consistency.

Yeah. I am fine with either creating a separate docker or doing it inside integration. Any preference @xzdandy?

The current PR looks good to me!

@Chitti-Ankith Chitti-Ankith merged commit b152a6d into georgia-tech-db:staging Sep 1, 2023
hershd23 pushed a commit to hershd23/evadb that referenced this pull request Sep 4, 2023
This diff adds extends the database interface to add support for SQLite.

Test Plan : UT

---------

Co-authored-by: Ankith Reddy Chitti <chitti@lawn-128-61-2-2.lawn.gatech.edu>
Co-authored-by: Ankith Reddy Chitti <chitti@Ankiths-Air.attlocal.net>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants