Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Updates evadb apps #1123

Merged
merged 3 commits into from
Sep 18, 2023
Merged

Updates evadb apps #1123

merged 3 commits into from
Sep 18, 2023

Conversation

pchunduri6
Copy link
Contributor

Update evadb apps

  1. Change udf to function
  2. Update queries to cursor.query("...")

@jiashenC
Copy link
Member

@pchunduri6 Thanks, it looks good to me. Can you fix the Linter issue and I will merge it.

jiashenC
jiashenC requested changes Sep 15, 2023
View reviewed changes
Copy link
Member

@jiashenC jiashenC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, fix the linter.

@jiashenC jiashenC self-requested a review September 18, 2023 16:56
jiashenC
jiashenC previously approved these changes Sep 18, 2023
View reviewed changes
@jiashenC jiashenC dismissed their stale review September 18, 2023 16:57

The print checking logic is wrong.

@jiashenC jiashenC self-requested a review September 18, 2023 16:59
@jiashenC jiashenC merged commit 11fa571 into staging Sep 18, 2023
@jiashenC jiashenC deleted the update-apps branch September 18, 2023 16:59
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jiashenC jiashenC jiashenC approved these changes

@jarulraj jarulraj Awaiting requested review from jarulraj

@gaurav274 gaurav274 Awaiting requested review from gaurav274

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pchunduri6 @jiashenC