Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add stable diffusion integration #1240

Merged
merged 18 commits into from
Oct 15, 2023
Merged

Conversation

xzdandy
Copy link
Collaborator

@xzdandy xzdandy commented Sep 30, 2023

Reopen the #1111.

@xzdandy xzdandy added the AI Engines Features, Bugs, related to AI Engines label Sep 30, 2023
@xzdandy xzdandy added this to the v0.3.7 milestone Sep 30, 2023
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@xzdandy
Copy link
Collaborator Author

xzdandy commented Sep 30, 2023

Quick notice:

  1. Fix testcases
  2. Please change the notebook name and if notebook also does not work on circle ci, we can skip the it. You can do it in script/test/test.sh. Do let us know why it does not work.
  3. Add a documentation to the function under https://evadb.readthedocs.io/en/stable/source/reference/ai/index.html
  4. Both test/integration_tests/long/functions/test_dalle.py and test/integration_tests/long/functions/test_selfdiffusion.py look unit tests instead of long integration tests, which is fine. If so, move them to test/unit_tests.

@xzdandy xzdandy modified the milestones: v0.3.7, v0.3.8 Sep 30, 2023
@sudoboi sudoboi requested a review from aryan-rajoria October 12, 2023 03:47
@xzdandy
Copy link
Collaborator Author

xzdandy commented Oct 12, 2023

Hi @sudoboi, I do not have permission to push to your fork since I am not the reviewer. We need to change the script/test/test.sh to skip the tutorials/18-stable-diffusion.ipynb due to the replicate API key. Overall looks great! Thanks!

@xzdandy xzdandy requested review from jiashenC and gaurav274 October 15, 2023 07:13
@xzdandy
Copy link
Collaborator Author

xzdandy commented Oct 15, 2023

Hi @gaurav274 and @jiashenC, please help review the PR. The PR looks good to me. But I reopened the PR, so I can not approve.

@xzdandy xzdandy merged commit bf02232 into georgia-tech-db:staging Oct 15, 2023
RichardZhangRZ pushed a commit to RichardZhangRZ/evadb that referenced this pull request Oct 23, 2023
Reopen the georgia-tech-db#1111.

---------

Co-authored-by: sudoboi <guyphysicist@gmail.com>
Co-authored-by: Abhijith S Raj <63101280+sudoboi@users.noreply.github.com>
a0x8o pushed a commit to alexxx-db/eva that referenced this pull request Oct 30, 2023
Reopen the georgia-tech-db#1111.

---------

Co-authored-by: sudoboi <guyphysicist@gmail.com>
Co-authored-by: Abhijith S Raj <63101280+sudoboi@users.noreply.github.com>
a0x8o pushed a commit to alexxx-db/eva that referenced this pull request Oct 30, 2023
Reopen the georgia-tech-db#1111.

---------

Co-authored-by: sudoboi <guyphysicist@gmail.com>
Co-authored-by: Abhijith S Raj <63101280+sudoboi@users.noreply.github.com>
a0x8o pushed a commit to alexxx-db/eva that referenced this pull request Nov 22, 2023
Reopen the georgia-tech-db#1111.

---------

Co-authored-by: sudoboi <guyphysicist@gmail.com>
Co-authored-by: Abhijith S Raj <63101280+sudoboi@users.noreply.github.com>
a0x8o pushed a commit to alexxx-db/eva that referenced this pull request Nov 22, 2023
Reopen the georgia-tech-db#1111.

---------

Co-authored-by: sudoboi <guyphysicist@gmail.com>
Co-authored-by: Abhijith S Raj <63101280+sudoboi@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
AI Engines Features, Bugs, related to AI Engines
Projects
Development

Successfully merging this pull request may close these issues.

4 participants