Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Support semicolon and escaped strings in lark #1339

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Support semicolon and escaped strings in lark #1339

merged 1 commit into from
Nov 6, 2023

Conversation

pchunduri6
Copy link
Contributor

Support semi-colons in string literals for queries of the form:

"""SELECT ChatGPT("Here's a; question", "This is the context") FROM TAIPAI;"""

Also support string escape to run ChatGPT queries more easily:

"""SELECT ChatGPT('Here\\'s a question', 'This is the context') FROM TAIPAI;"""

@pchunduri6 pchunduri6 changed the title support semicolon and escaped strings in lark Support semicolon and escaped strings in lark Nov 3, 2023
@jarulraj jarulraj self-requested a review November 6, 2023 00:28
@jarulraj
Copy link
Member

jarulraj commented Nov 6, 2023 •
edited
Loading

The PR looks good to me @pchunduri6. Anything pending?

@pchunduri6 pchunduri6 marked this pull request as ready for review November 6, 2023 01:20
@pchunduri6
Copy link
Contributor Author

The PR looks good to me @pchunduri6. Anything pending?

It should be good to merge @jarulraj. Can you merge it?

@jarulraj jarulraj merged commit 6929103 into staging Nov 6, 2023
1 check passed
@jarulraj jarulraj deleted the lark-string-literal branch November 6, 2023 02:11
@a0x8o a0x8o mentioned this pull request Nov 20, 2023
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jarulraj jarulraj Awaiting requested review from jarulraj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pchunduri6 @jarulraj