Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Relax ToWkt impls to work with CoordNum #100

Closed
rmanoka opened this issue May 17, 2022 · 1 comment · Fixed by #101
Closed

Relax ToWkt impls to work with CoordNum #100

rmanoka opened this issue May 17, 2022 · 1 comment · Fixed by #101

Comments

@rmanoka
Copy link
Contributor

rmanoka commented May 17, 2022

Currently the ToWkt impls. need T: CoordFloat + Display on the geometry. Can this be relaxed to T: CoordNum + Display? Or, is this a big structural change? Ideally, even FromWkt should rather use CoordNum + FromStr than CoordFloat if that's possible.

@michaelkirk
Copy link
Member

I think it should be possible! It'll require some changes to the underlying Wkt type which is currently restricted to num_traits::Float - but I can't imagine why it'd actually be relying on Float behavior for anything.

I can take a look tomorrow.

@bors bors bot closed this as completed in 2b8c023 May 20, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants