ToWkt for integer types #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmanoka
approved these changes
May 18, 2022
3 tasks
|
bors r=rmanoka |
|
Build succeeded: |
Closed
bors bot
added a commit
that referenced
this pull request
Jun 16, 2022
103: TryFromWkt for integer geometries r=urschrei a=michaelkirk - [x] I agree to follow the project's [code of conduct](https://github.com/georust/geo/blob/master/CODE_OF_CONDUCT.md). - [x] I added an entry to `CHANGES.md` if knowledge of this change could be valuable to users. - [x] I ran cargo fmt --- Fixes #102 ~~This is based on #101, which `@rmanoka` already approved (thanks!), but I'm going to wait just a bit longer to merge it in case someone else wanted to take a look at it.~~ **update:** #101 has been merged, and this is ready for review! Co-authored-by: Michael Kirk <michael.code@endoftheworl.de>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES.mdif knowledge of this change could be valuable to users.Add's serialization for integer types.
FIXES #100
In my first attempt, I also tried to add integer support in deserialization (
TryFromWkt) but I hit a speed bump. I'll open an issue with details momentarily.