Updated soil NOx scheme from Yi Wang et al. (2021) as an option #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion from Yi Wang et al. (2021). A new option "Use soil temperature" has been added to the soil NOx extension. When this option is activated, the soil temperature field from the external model (TSOIL1) will be passed to the SoilTemp function instead of T2M (the temperature at 2 meters). The algorithm in the SoilTemp function will also use the updated calculation from Yi Wang et al. (2021). By default, this function will be turned off until the full record of TSOIL1 fields can be archived for input. The error messages in the soil NOx extension have also been updated here to provide more detailed information. Signed-off-by: Melissa Sulprizio <mpayer@seas.harvard.edu>
Signed-off-by: Melissa Sulprizio <mpayer@seas.harvard.edu>
(1) Remove spaces from from the UseSoilTemperature option so that it can
be used in HEMCO logical brackets in HEMCO_Config.rc.
(2) Only set ExtState%TSOIL1%DoUse = .TRUE. if UseSoilTemp is true.
Signed-off-by: Melissa Sulprizio <mpayer@seas.harvard.edu>
Signed-off-by: Melissa Sulprizio <mpayer@seas.harvard.edu>
msulprizio
added
category: Feature Request
Compile issues in hcox_soilnox_mod.F90 are addressed here, including adding a missing ENDIF and passing the Inst pointer to function SOILTEMP. The error messages in subroutine HCOX_SoilNOx_Run have also been updated here to be more descriptive. Signed-off-by: Melissa Sulprizio <mpayer@seas.harvard.edu>
…Temp is true Signed-off-by: Melissa Sulprizio <mpayer@seas.harvard.edu>
yantosca
approved these changes
Sep 6, 2024
There was a problem hiding this comment.
Thanks @msulprizio, this is good to merge. Also thanks for putting in better error messages. :-)
|
After merging locally atop 14.5.0-alpha.10, all GEOS-Chem Classsic integration tests and GCHP integration tests passed. |
==============================================================================
GEOS-Chem Classic: Execution Test Results
CodeDir : 5e00d7e GEOS-Chem update: Merge PR #2457 (Update Is_Photolysis tags)
GEOS-Chem : 084a8cf8d Merge PR #2462 (Bug fix: ALK6 in HEMCO_Config.rc should be ALK7)
HEMCO : c6a9d46 Merge PR #287 (Updated Y. Wang soil NOx scheme as an option)
Cloud-J : 6bf4a36 Merge pull request #26 from geoschem/feature/define_max_rather_than_exact_num_jvalues
HETP : 2a99b24 Merge pull request #2 from geoschem/bugfix/initialize_local_variables
Using 24 OpenMP threads
Number of execution tests: 30
Submitted as SLURM job: 46770790
==============================================================================
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%% All execution tests passed! %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Melissa Sulprizio
Institution: Harvard
Describe the update
This is the corresponding pull request for geoschem/geos-chem#1288 and should be merged in alongside geoschem/geos-chem#2430.
Yi Wang (@ywang37) updated the soil NOx algorithm in HEMCO to utilize soil temperature as described in Yi Wang et al. (ERL, 2021).
A new option "UseSoilTemperature" has been added to the soil NOx extension. When this option is activated, the soil temperature field from the external model (TSOIL1) will be passed to the SoilTemp function instead of T2M (the temperature at 2 meters). The algorithm in the SoilTemp function will also use the updated calculation from Yi Wang et al. (2021). By default, this function will be turned off until the full record of TSOIL1 fields can be archived for input.
The error messages in the soil NOx extension have also been updated here to provide more detailed information.
Expected changes
This is a zero-difference change with respect to the full-chemistry benchmark because this updated scheme is off by default. To view the expected changes when the algorithm is used, see geoschem/geos-chem#1288 (comment) in the original Github issue.
Reference(s)
Related Github Issue