Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix trace metals simulation name in config file comments #2560

Merged

Conversation

ihough
Copy link
Contributor

@ihough ihough commented Nov 7, 2024

Name and Institution (Required)

Name: Ian Hough
Institution: Université Grenoble Alpes

Describe the update

Changes 'transport tracers' to 'trace metals' in the trace metals simulation rc file templates

Expected changes

No changes to model output

Reference(s)

N/A

Related Github Issue

trace metals

ubuntu and others added 3 commits November 4, 2024 20:35
GeosCore/cldj_interface_mod.F90
- Remove dry-run checks for files that are no longer needed in
  Cloud-J v8+.

run/shared/download_data.py
- Added line to replace "CHEM_INPUTS//" with "CHEM_INPUTS/"
- Renamed "mirror" -> "portal" to be consistent w/ documentation
- Trimmed trailing whitespace

run/shared/download_data.yml
- Renamed "mirror" -> "portal" to be consistent w/ documentation
- Added "geoschem+aws", "geoschem+http", "nested+aws", "nested+http"
  portal metadata
- NOTE: Will need to change GEOSCHEM_RESTARTS/GC_14.3.0 to
  GEOSCHEM_RESTARTS/GC_14.5.0 before release

CHANGELOG.md
- Updated accordingly

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
run/GCHP/createRunDir.sh
run/shared/download_data.yml
- Fullchem, tagO3, and aerosol simulations now will download
  restart files from GEOSCHEM_RESTARTS/GC_14.5.0.  This folder includes
  restart files taken from the 14.5.0 1-year benchmark.

CHANGELOG.md
- Updated accordingly

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
@yantosca yantosca self-requested a review November 7, 2024 15:53
@yantosca yantosca added this to the 14.5.1 milestone Nov 7, 2024
Copy link
Contributor

@yantosca yantosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ihough. This PR only touches comments and so won't affect any output. We can bring this into our patch version 14.5.1.

@yantosca yantosca self-assigned this Nov 7, 2024
@yantosca yantosca added topic: Configuration Files Related to GEOS-Chem configuration files no-diff-to-benchmark This update will not change the results of fullchem benchmark simulations category: Bug Fix Fixes a previously-reported bug labels Nov 7, 2024
This merge brings PR geoschem#2555 (Dry run updates for GEOS-Chem Classic
14.5.0, by @yantosca) into the GEOS-Chem 14.5.0 developoment stream.

This PR updates the data portals from which data can be downloaded,
as there are now the new "GEOS-Chem Input Data" and "GEOS-Chem Nested
Input Data" portals hosted on AWS.  Also, restart files for fullchem,
tagO3, and aerosol-only simulations will be downloaded from the
ExtData/GEOSCHEM_RESTARTS/GC_14.5.0, which contains restart files from
the 14.5.0 1-year benchmarks.

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
@yantosca yantosca changed the base branch from main to dev/no-diff-to-benchmark November 7, 2024 16:34
CHANGELOG.md
- Updated version number to 14.5.0 in anticipation of the
  GEOS-Chem 14.5.0 release

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
Updated version numbers in:
- CHANGELOG.md

Please see CHANGELOG.md for updates added to this version.

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
This merge brings in the updates from the 14.5.0 release back
into the dev/no-diff-to-benchmark branch.

See the CHANGELOG.md for updates.

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
This merge brings PR geoschem#2560 (Fix trace metals simulation name in
config file comments, by @ihough) into the GEOS-Chem
"no-diff-to-benchmark" development stream.

This PR fixes incorrect comments in configuration files.
Also, merge conflicts in CHANGELOG.md have been resolved.

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.ed
Copy link
Contributor

@yantosca yantosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ihough: I have merged this up to the dev/no-diff-to-benchmark branch and have resolved merge commits. Good to merge.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
category: Bug Fix Fixes a previously-reported bug no-diff-to-benchmark This update will not change the results of fullchem benchmark simulations topic: Configuration Files Related to GEOS-Chem configuration files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some trace metals simulation config files claim to be for transport tracers simulations
2 participants