Fixed PDOWN definition and re-evaporation requirement for washout #2573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @yuanjianz, could you comment on the expected changes on the benchmark? Have you done test runs? |
lizziel
added
category: Bug
lizziel
approved these changes
Jan 9, 2025
|
@yuanjianz, if you are okay with it I will update this PR to latest dev for merge. |
|
Sure, thanks @lizziel. |
# Conflicts: # CHANGELOG.md Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
lizziel
force-pushed
the
bugfix/pdown-down-edge-reevap-criteria-convection
branch
from
ac3cc50 to
b3756b1
Compare
lizziel
approved these changes
Jan 23, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Yuanjian Zhang
Institution: WashU
Describe the update
Related Github Issue
Based on discussion with @viral211 in #2523