This repository was archived by the owner on Oct 21, 2024. It is now read-only.
Profiler test udp connection #51
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
baselqyqony
commented
Jul 8, 2021
baselqyqony
commented
- add TestUDPUsingSchedular test to ProfilerTest
gerazo
suggested changes
Jul 15, 2021
|
|
||
| #include <cstdio> | ||
| #include <thread> | ||
|
|
||
| #include "gtest/gtest.h" |
There was a problem hiding this comment.
Putting the test headers in front of anything else does make sense in this case.
test/ProfilerTest.cpp
Outdated
| !packet_to_process.IsEmpty(); packet_to_process = pc.Poll()) { | ||
| } | ||
| // test receiving data | ||
| EXPECT_EQ(Receive(), true); |
There was a problem hiding this comment.
This line fails in clang release (returns false). It would be good to find out, why.
|
The last one could trigger the same problem also in Debug. This means that clang, the compiler does something different which causes this problem. |
…ecieved bytes are different
|
I found the problem root cause, in the release on clang phase the buffer has different values from the expected ones, because of that the function receives returns false |
|
Thank @baselqyqony nice catch. I will look into it. I am creating an issue. |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.