export several files to zip file (#203)

[schochastics]

No description provided.

[schochastics]

@chainsawriot please have a look if the logic I used makes sense to you

[chainsawriot]

Just two comments

[chainsawriot]

1. Use && (gp)

2. This won't write to new directory:

## if archivea is not created
export_list(mylist, file = paste0("file_", 1:3, ".xlsx"), archive = "archivea")

Maybe check and create it first?

[chainsawriot]

Also, I suggest adding normalizePath to outfiles and archive. Windows cannot handle "~/" without normalizePath

outfiles <- base::normalizePath(outfiles)
archive <- base::normalizePath(archive) ## if it is not ""

ropensci/readODS#157

[chainsawriot]

@schochastics I checked and it works fine, except the case of writing to new directory.

[schochastics]

@chainsawriot Thanks will address the comments

@schochastics I checked and it works fine, except the case of writing to new directory.

Yes forgot to ask you about that. export does not create a new dir if it doesn't exist

R> export(mtcars,"i_dont_exist/test.csv")
Error in data.table::fwrite(x, file = file, sep = sep, row.names = row.names,  : 
  No such file or directory: 'i_dont_exist/test.csv'. Unable to create new file for writing (it does not exist already). Do you have permission to write here, is there space on the disk and does the path exist?

I can make export_list create a new dir if it doesnt exist, but then we probably should also do it for export?

[chainsawriot]

@schochastics Thanks for finding this out. I will open a new issue and fix that.

[schochastics]

@chainsawriot actually since export_list calls export for the default case, I will only implement the "new dir" feature for the archive

[chainsawriot]

@schochastics OK, just leave it like that and I will fix #347

I think the expected output for test_export_list.R:25:5 should be the normalizedPath(archive)

[chainsawriot]

@schochastics Great! Thank you!