feat: lightning channel flows #1000
Conversation
| }; | ||
|
|
||
| export function PayLightningInvoice({ invoice }: PayLightningInvoiceProps) { | ||
| export function PayLightningInvoice({ |
There was a problem hiding this comment.
This was a general "Pay Lightning Invoice" component and now it is coupled with the LSP order. This doesn't seem to make sense to me, can you double-check your changes?
| @@ -29,7 +29,11 @@ function SidebarHint() { | |||
| title="New Channel" | |||
| description="You're currently opening a new channel" | |||
| buttonText="View Channel" | |||
| buttonLink="/channels/order" | |||
| buttonLink={`${ | |||
There was a problem hiding this comment.
how does the outgoing flow work?
And when I click this link when I'm currently opening an incoming channel, what I see on the page is wrong.
| </TooltipContent> | ||
| </Tooltip> | ||
| </TooltipProvider> | ||
| <MempoolAlert /> |
There was a problem hiding this comment.
This is shown in the wrong place compared to in master
| ) && <ChannelPublicPrivateAlert />} | ||
| {selectedPeer?.note && <ChannelPeerNote peer={selectedPeer} />} | ||
|
|
||
| <DuplicateChannelAlert |
There was a problem hiding this comment.
This is shown when it should not be.
| > | ||
| <div className="flex items-center gap-3 justify-between"> | ||
| <div className="flex items-center gap-3"> | ||
| {peer.name !== "Custom" && ( |
There was a problem hiding this comment.
There is no custom any more. If you make big changes to these flows can you consider what needs to be removed and what needs to be kept?
| : "" | ||
| }`} | ||
| onClick={() => | ||
| setSelectedPeer(peer) |
There was a problem hiding this comment.
Should this also close the sheet?
| onClick={prevStep} | ||
| variant="secondary" | ||
| > | ||
| Back |
There was a problem hiding this comment.
What does this do when you are currently opening a channel?
lightning channel flow using stepper component