Skip to content

chore: upgrade dependencies and migrate example to vite #68

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 9 commits into from
Nov 26, 2024

Conversation

aaronleopold
Copy link
Member

@aaronleopold aaronleopold commented Nov 22, 2024

I'm opening this PR as a draft to gather feedback primarily on the example app migration before proceeding. To reiterate my thoughts on the matter:

The standard for bootstrapping a React app has moved away from create-react-app, which is no longer even mentioned by the folks at Facebook in the “Getting Started” guide (although in fairness, they push using a framework). Another interesting read here. Vite is generally the de facto bundler for people wanting a quick entry into developing a React app without a full framework these days.

An overview of the changes is as follows:

  • Upgrade eslint and refactor configs according to the migration guide
    • See note about chai syntax causing a false positive for a lint rule
  • Format areas of the code which seemed to have been missed previously
    • Add CHANGELOG.md to the .prettierignore file to keep it more static
  • Migrate the create-react-app example to use vite
    • Add a localized eslint config to the example so people can get it out the gate
    • Moved dependencies to devDependencies as needed
  • Remove live-server, just use serve
  • Patch remaining vulnerabilities

@jreyes33
Copy link
Member

This looks great, thanks!

I think I found a path to have non-vulnerable cookie and ws packages without needing the explicit resolutions. @aaronleopold, do you mind if I push to this branch?

@aaronleopold
Copy link
Member Author

I think I found a path to have non-vulnerable cookie and ws packages without needing the explicit resolutions. @aaronleopold, do you mind if I push to this branch?

Not at all! Please, do 🙂

by upgrading the intermediate `socket.io` and `engine.io` deps.
@aaronleopold aaronleopold marked this pull request as ready for review November 22, 2024 18:00
Copy link
Contributor

@pvditto pvditto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aaronleopold aaronleopold merged commit b0be806 into master Nov 26, 2024
1 check passed
@aaronleopold aaronleopold deleted the al/upgrade-dependencies branch November 26, 2024 15:05
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants