add log and continue when step parsing fails for completion #2632

[sriv]

No description provided.

[gaugebot]

@sriv Thank you for contributing to gauge. Your pull request has been labeled as a release candidate 🎉🎉.

Merging this PR will trigger a release.

Please bump up the version as part of this PR.

Instructions to bump the version can found at CONTRIBUTING.md

If the CONTRIBUTING.md file does not exist or does not include instructions about bumping up the version, please looks previous commits in git history to see what changes need to be done.

[github-actions]

Benchmark Results

java_simple_parallel.csv

Commit	CPU	Memory	Time	ExitCode
684d870	22%	75992	0:24.47	0
afc97cb	23%	73892	0:24.89	0
aff43ef	21%	66656	0:24.91	0
5e2fc9b	24%	70640	0:24.43	0

java_maven_serial.csv

Commit	CPU	Memory	Time	ExitCode
684d870	63%	205604	0:19.21	0
afc97cb	71%	189880	0:17.03	0
aff43ef	72%	186092	0:17.10	0
5e2fc9b	74%	183716	0:16.39	0

java_maven_parallel.csv

Commit	CPU	Memory	Time	ExitCode
684d870	33%	177512	0:34.73	0
afc97cb	33%	172916	0:32.61	0
aff43ef	32%	175516	0:35.05	0
5e2fc9b	35%	174332	0:31.89	0

java_simple_serial.csv

Commit	CPU	Memory	Time	ExitCode
684d870	53%	67684	0:11.47	0
afc97cb	40%	65936	0:15.87	0
aff43ef	45%	66284	0:14.56	0
5e2fc9b	54%	70460	0:12.14	0

java_gradle_serial.csv

Commit	CPU	Memory	Time	ExitCode
684d870	10%	130832	0:25.82	0
afc97cb	9%	122360	0:25.03	0
aff43ef	10%	121088	0:25.37	0
5e2fc9b	10%	122392	0:24.93	0

java_gradle_parallel.csv

Commit	CPU	Memory	Time	ExitCode
684d870	5%	116480	0:45.44	0
afc97cb	6%	126520	0:46.25	0
aff43ef	5%	118848	0:48.92	0
5e2fc9b	5%	122100	0:45.91	0

java_simple_multithreaded.csv

Commit	CPU	Memory	Time	ExitCode
684d870	34%	68012	0:10.56	0
afc97cb	26%	69952	0:13.39	0
aff43ef	40%	64600	0:09.75	0
5e2fc9b	37%	68724	0:10.03	0

java_maven_multithreaded.csv

Commit	CPU	Memory	Time	ExitCode
684d870	58%	183140	0:15.71	0
afc97cb	60%	173792	0:15.06	0
aff43ef	60%	170756	0:15.91	0
5e2fc9b	62%	169328	0:14.61	0

java_gradle_multithreaded.csv

Commit	CPU	Memory	Time	ExitCode
684d870	10%	123668	0:24.49	0
afc97cb	10%	97660	0:22.99	0
aff43ef	9%	121700	0:24.43	0
5e2fc9b	9%	95420	0:24.11	0

Notes

• The results above are generated by running against seed projects in https://github.com/getgauge/gauge-benchmark
• These results are not persisted, but on merging to master the benchmark will be rerun.
• These benchmark are run in Github Actions' agents, which are virtualized. Results are not to be taken as actual benchmarks.Rather, these are indicative numbers and make sense for comparison.

---

See Workflow log for more details.

[chadlwilson]

Thanks!

I saw many adjacent places where errors are being swallowed in this parsing code (in ways that would cause crashes on nil) so I began to assume I was missing something.

[sriv]

Yeah, i suppose that is a bad idea. I will give it another go when I find a bit more time, but at the least I'd say we should log it