Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add "trigger" support to respond to non-command text #185

Merged
merged 6 commits into from
Jan 1, 2022

Conversation

theothertomelliott
Copy link
Contributor

Fixes #117

A single trigger is added for commands, matching against a regex, without any parameters permitted.
@clockworksoul clockworksoul added the enhancement New feature or request label Dec 6, 2021
This change updates triggers to allow for multiple triggers per command, in a format that will allow extrat config later.

The parameters for the command are also corrected to include the first token.

Tests have been updated appropriately.
@theothertomelliott theothertomelliott marked this pull request as ready for review December 12, 2021 18:13
@clockworksoul clockworksoul self-assigned this Dec 13, 2021
…nd triggers.

Add unit tests to verify expected behavior in Channel and Direct messages.
@clockworksoul
Copy link
Member

A couple of nits but this LGTM!
This change is a really big deal. Feel free to merge at will sir!

@theothertomelliott theothertomelliott merged commit 0842481 into develop Jan 1, 2022
@theothertomelliott theothertomelliott deleted the theothertomelliott/issue117 branch April 10, 2022 23:57
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants