WIP: allow kubernetes Secrets to be injected into the worker's environment #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this PR! Apologies for not looking at it sooner: the real-life job, holidays, and a little case of the COVID have slowed me down a bit. I'm absolutely not opposed to merging this almost as-is (barring the trivial casing request). It may be uprooted by the dynamic configuration changes I'm working on right now, but then again it's perfectly possible that it could stick around! The future is unclear. Also, I think you got some bonus functionality out of this as well: I don't think that the in-memory DAL implementation actually needs any additional logic. This should work as-is for that as well. |
|
Also, once this merges, I'd be happy to cut a new version into main for you. |
|
Thanks, I'd appreciate a merge and new revision if being cut, if trivial. |
|
Can do. |
clockworksoul
pushed a commit
to clockworksoul/gort
that referenced
this pull request
Jan 4, 2022
…nment (getgort#189) Allow kubernetes Secrets to be injected into the worker's environment (getgort#189)
clockworksoul
added a commit
that referenced
this pull request
Jun 30, 2022
* Update TODO * Minor: command help output formatting (#200) Fix help output formatting for various commands. * WIP: allow kubernetes Secrets to be injected into the worker's environment (#189) Allow kubernetes Secrets to be injected into the worker's environment (#189) * Rename config.IsDefined to simply config.Defined (#206) * Fix for Postgres connection leak bug (#208) * Fix for database creation bug (#183) * Upgrade Go version and dependencies * Version fix * Ignore VS Code workspaces * Oops * Bump version in Github Actions for parity with mod file * Rm accidental file Co-authored-by: Matthew Titmus <mtitmus@yext.com> Co-authored-by: Matt Miller <msm93v2@gmail.com>
clockworksoul
added a commit
that referenced
this pull request
Jul 2, 2022
* Update TODO * Minor: command help output formatting (#200) Fix help output formatting for various commands. * WIP: allow kubernetes Secrets to be injected into the worker's environment (#189) Allow kubernetes Secrets to be injected into the worker's environment (#189) * Rename config.IsDefined to simply config.Defined (#206) * Fix for Postgres connection leak bug (#208) * Fix for database creation bug (#183) * Ignore VS Code workspaces * Oops Co-authored-by: Matthew Titmus <mtitmus@yext.com> Co-authored-by: Matt Miller <msm93v2@gmail.com>
clockworksoul
added a commit
that referenced
this pull request
Jul 2, 2022
* Update TODO * Minor: command help output formatting (#200) Fix help output formatting for various commands. * WIP: allow kubernetes Secrets to be injected into the worker's environment (#189) Allow kubernetes Secrets to be injected into the worker's environment (#189) * Rename config.IsDefined to simply config.Defined (#206) * Fix for Postgres connection leak bug (#208) * Fix for database creation bug (#183) * Ignore VS Code workspaces * Oops * Minor: make slice definitions idiomatic * Restore one declaration to prevent nil returns Co-authored-by: Matthew Titmus <mtitmus@yext.com> Co-authored-by: Matt Miller <msm93v2@gmail.com>
clockworksoul
added a commit
that referenced
this pull request
Jul 2, 2022
* Update TODO * Minor: command help output formatting (#200) Fix help output formatting for various commands. * WIP: allow kubernetes Secrets to be injected into the worker's environment (#189) Allow kubernetes Secrets to be injected into the worker's environment (#189) * Rename config.IsDefined to simply config.Defined (#206) * Fix for Postgres connection leak bug (#208) * Fix for database creation bug (#183) * Ignore VS Code workspaces * Oops Co-authored-by: Matthew Titmus <mtitmus@yext.com> Co-authored-by: Matt Miller <msm93v2@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated, this should probably be considered a WIP, it's only been implemented for postgres, and ideally it would let you 1) mount multiple secrets into the environment, and 2) mount Secrets into the worker's filesystem. this currently provides the functionality I need to use this bot in a more production'y manor right now, but I may circle back to do more work on it if time allows, and if it's not the totally wrong direction for this kind of thing that folks have envisioned for the project.