-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Chore: migrate dashboard-icons #4564
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
walkxcode himself, cool.
Well thanks for taking the time to PR, thanks for your project.
I think this contains an error at the moment, it's re-declaring the const and the (unintentionally?) added webp block is unreachable
The constant uses the same logic as the SVG and PNG retrieval. Folder links to jsDelivr show as unreachable because we’ve exceeded the ‘package’ limit. However, direct file links, such as https://cdn.jsdelivr.net/gh/homarr-labs/dashboard-icons/webp/1password.webp, will still work. |
Ah seems like we're missing the |
Ideally the PNGs should be removed completely as they have the same function as the WebPs but with a bigger size, but that's all up to you ofcourse. Let me know if you want the WebPs or PNGs :) |
Thanks. Yea we can make the fallback to webp, its support is pretty darn good at this point |
Actually I take that back. That would be breaking or at least kinda confusing. You can add webp if you like but please leave the png for now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again
Info: homarr-labs/dashboard-icons#797 (comment).
Note: The walkxcode/dashboard-icons repository will continue to function indefinitely but may no longer receive updates.