-
Notifications
You must be signed in to change notification settings - Fork 47
HTTP-63 Add caching #109
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
HTTP-63 Add caching #109
Conversation
Signed-off-by: David Radley <david_radley@uk.ibm.com>
* Use LookupFunction and AsyncLookupFunction interfaces * Add integration tests
6be2698
to
24ae7d0
Compare
...n/java/com/getindata/connectors/http/internal/table/lookup/AsyncHttpTableLookupFunction.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im super happy to see this finally added to the connector :)
Thanks @grzegorz8 !!!
...n/java/com/getindata/connectors/http/internal/table/lookup/AsyncHttpTableLookupFunction.java
Show resolved
Hide resolved
src/main/java/com/getindata/connectors/http/internal/table/lookup/HttpLookupTableSource.java
Show resolved
Hide resolved
@kristoffSC Build for 1.18.1 fails due to:
Any thoughts? |
Looks like jacoco report is not generated, logs show:
The reason may be related to this added configuration of maven-surefire-plugin
Documentation suggest to add |
|
Thanks. It helped. |
Co-authored-by: David Radley <david_radley@uk.ibm.com> Co-authored-by: Grzegorz Kołakowski <grzegorz.kolakowski@getindata.com>
Description
Introduce caching similar to the Flink JDBC connector, so long running synchronous Flink jobs can cache content resulting in less API calls.
Resolves #63
I took over this PR: #94 due to author inactivity.
PR Checklist