Str::template() callback support for 3.5.7 #3454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supports HTML for toggle and checkbox field labels
Renaming the argument is a breaking change in PHP 8 because of named arguments (users could have explicitly passed a named `fallback` argument which would then fail).
Because of initial release in 3.5.7
bastianallgeier
approved these changes
Jun 21, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
I've cherry-picked the original PR #3279 and made some improvements in the subsequent commits. Please see the commit descriptions for more details.
Release notes
Features
Str::template()(e.g. to escape query output)Enhancements
Str::template()now supports an$optionsarray that can containfallback,callback,start,endattributes. We plan to deprecate the old$fallback,$startand$endarguments in 3.6.0.Fixes
Breaking changes
None
Related issues/ideas
Ready?
When merging