-
-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Force close all drawers correctly #6620
base: develop-minor
Are you sure you want to change the base?
Conversation
Looks good except an error in console log:
Use following blueprint to reproduce: fields:
blocks:
type: blocks
fieldsets:
test:
fields:
addresses:
type: structure
fields:
contact:
type: object
fields:
blocks:
type: blocks Add a block (for ex: text block) to deepest level (object field named contact) and edit the block (to open block) and use browser backward. You'll see the error in browser console log. |
@afbora I cannot reproduce this |
invalid.mp4 |
@afbora could reproduce it! Though I think it's not like you write "add any block, e.g. text block", but needs to be a block with a textarea input (and the text block uses writer input instead). I yet have to understand if this error is actually related to this PR or not. |
Changelog
Fixes
Drawer keeps open when browser back/forward used #6030
Ready?
Unit tests for fixed bug/featureFor review team