Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Force close all drawers correctly #6620

Draft
wants to merge 1 commit into
base: develop-minor
Choose a base branch
from

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Aug 15, 2024

Changelog

Fixes

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature
  • Tests and CI checks all pass

For review team

  • Add changes & docs to release notes draft in Notion

@distantnative distantnative added this to the 4.4.0 milestone Aug 15, 2024
@distantnative distantnative self-assigned this Aug 15, 2024
@distantnative distantnative requested a review from afbora August 15, 2024 20:55
@distantnative distantnative marked this pull request as ready for review August 15, 2024 20:55
@afbora afbora linked an issue Aug 16, 2024 that may be closed by this pull request
@afbora
Copy link
Member

afbora commented Aug 16, 2024

Looks good except an error in console log:

TypeError: Cannot read properties of null (reading '$invalid')

Use following blueprint to reproduce:

fields:               
  blocks:
    type: blocks
    fieldsets:
      test:
        fields:                    
          addresses:
            type: structure
            fields:                        
              contact:
                type: object
                fields:
                  blocks:
                    type: blocks

Add a block (for ex: text block) to deepest level (object field named contact) and edit the block (to open block) and use browser backward. You'll see the error in browser console log.

@distantnative
Copy link
Member Author

@afbora I cannot reproduce this

@afbora
Copy link
Member

afbora commented Aug 17, 2024

@distantnative

invalid.mp4

@distantnative
Copy link
Member Author

@afbora could reproduce it! Though I think it's not like you write "add any block, e.g. text block", but needs to be a block with a textarea input (and the text block uses writer input instead).

I yet have to understand if this error is actually related to this PR or not.

@distantnative distantnative marked this pull request as draft August 31, 2024 11:24
@bastianallgeier bastianallgeier modified the milestones: 4.5.0, 4.6.0 Nov 12, 2024
@distantnative distantnative modified the milestones: 4.6.0, 4.7.0 Jan 17, 2025
@distantnative distantnative modified the milestones: 4.7.0, 5.1.0 Feb 10, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Drawer keeps open when browser back/forward used
3 participants