Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: allow passing tuples and list values as query params #291

Merged
merged 1 commit into from
Jan 7, 2025
Merged

feat: allow passing tuples and list values as query params #291

merged 1 commit into from
Jan 7, 2025

Conversation

steved
Copy link
Contributor

@steved steved commented Dec 10, 2024 •
edited
Loading

Allows passing multiple list param values such as with status[] in list subscriptions.

vincent-pochet
vincent-pochet approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@vincent-pochet vincent-pochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this pull request 👍
It looks good, I'm about to merge it. It will be part of the next release.

@vincent-pochet
Copy link
Contributor

@steved it looks like tests are failing with Python 3.9.
As this version is still supported until the end of 2025, I cannot merge it for now.

@steved
feat: allow passing tuples and list values as query params
a5e52f4 
Allows passing multiple list param values such as with 'status[]'.
@steved steved force-pushed the steved/query-pairs-list branch from 3988d9a to a5e52f4 Compare December 23, 2024 18:37
@steved
Copy link
Contributor Author

steved commented Dec 23, 2024

@steved it looks like tests are failing with Python 3.9. As this version is still supported until the end of 2025, I cannot merge it for now.

Ah my bad. Updated the PR to switch back to Union!

@steved steved requested a review from vincent-pochet January 6, 2025 22:43
@vincent-pochet vincent-pochet merged commit e566031 into getlago:main Jan 7, 2025
6 checks passed
@vincent-pochet
Copy link
Contributor

Thank you for the fix @steved!
It will be part of the coming release

@steved steved deleted the steved/query-pairs-list branch January 7, 2025 17:55
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@vincent-pochet vincent-pochet Awaiting requested review from vincent-pochet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@steved @vincent-pochet