Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Admin: Increase SFN test duration #8437

Merged

Conversation

bblommers
Copy link
Collaborator

The tests against AWS tend to fail for two reason:

  • The SFN executions take too long, causing the test to timeout
  • The overall tests take too long, causing the IAM credentials to timeout

This should fix both.

@bblommers bblommers added this to the 5.0.25 milestone Dec 26, 2024
Copy link

codecov bot commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.60%. Comparing base (1e4364d) to head (3adf58e).
Report is 7 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8437   +/-   ##
=======================================
  Coverage   94.60%   94.60%           
=======================================
  Files        1167     1168    +1     
  Lines      101685   101707   +22     
=======================================
+ Hits        96198    96223   +25     
+ Misses       5487     5484    -3     
Flag Coverage Δ
servertests 28.82% <ø> (-0.01%) ⬇️
unittests 94.58% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bblommers bblommers marked this pull request as ready for review December 26, 2024 19:38
@bblommers bblommers merged commit 5ab97e5 into getmoto:master Dec 26, 2024
53 checks passed
@bblommers bblommers deleted the admin/increase-aws-test-duration branch December 26, 2024 19:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant