Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Glue] Added Connections Support #8626

Merged
merged 4 commits into from
Feb 26, 2025

Conversation

zkarpinski
Copy link
Contributor

@zkarpinski zkarpinski commented Feb 26, 2025

  • CreateConnection
  • GetConnection
  • GetConnections
  • Only display Public Address if a subnet is provided.
    -- The PublicAddress field is present only when you create a non-virtual private cloud (VPC) DevEndpoint." per Boto3 docs

Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.74%. Comparing base (a1af2a8) to head (5cc2ad5).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8626   +/-   ##
=======================================
  Coverage   92.73%   92.74%           
=======================================
  Files        1251     1251           
  Lines      108379   108434   +55     
=======================================
+ Hits       100507   100564   +57     
+ Misses       7872     7870    -2     
Flag Coverage Δ
servertests 28.08% <13.33%> (-0.01%) ⬇️
unittests 92.71% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bblommers bblommers added this to the 5.1.1 milestone Feb 26, 2025
@bblommers bblommers merged commit b7c89b0 into getmoto:master Feb 26, 2025
54 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants