Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Admin: Remove typing_extensions module #8630

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

bblommers
Copy link
Collaborator

Fixes #8627

FYI @bpandola - a little refactoring to get rid of this dependency. I replaced TypeAlias completely because it is a) only introduced in 3.10, and b) was deprecated again in 3.12. It seems to run fine without it, so I think it's OK? Happy to be corrected though, typing is not my strong suit. :)

@bpandola
Copy link
Collaborator

@bblommers Closed my PR in favor of yours. Python typing is definitely not my strong suit. Still wondering if maybe we should only install requirements-tests.txt for CI to try to catch this automatically going forward.

@bblommers
Copy link
Collaborator Author

Still wondering if maybe we should only install requirements-tests.txt for CI to try to catch this automatically going forward.

True, that does make sense. Only install -dev when linting, installing -tests only when running tests.

@bblommers bblommers marked this pull request as ready for review February 26, 2025 21:59
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.74%. Comparing base (694ce1f) to head (2189f50).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8630      +/-   ##
==========================================
- Coverage   92.74%   92.74%   -0.01%     
==========================================
  Files        1251     1251              
  Lines      108444   108442       -2     
==========================================
- Hits       100575   100573       -2     
  Misses       7869     7869              
Flag Coverage Δ
servertests 28.08% <100.00%> (-0.01%) ⬇️
unittests 92.71% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bpandola
Copy link
Collaborator

@bblommers Thanks for doing this. I felt bad that I had caused a regression, so I was trying (and failing) earlier to address this via the GitHub editor on my phone. 😆

@bpandola bpandola merged commit 81f5fd1 into getmoto:master Feb 27, 2025
54 checks passed
@bblommers bblommers deleted the admin/remove-typing-extensions branch February 27, 2025 09:51
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

typing_extensions introduced as prod dependency where it should not have been
2 participants