Warn about <2024.1 entities spec and update tests

[ktuite]

Closes getodk/central#730

I updated the versions in testData.forms.simpleEntity and testData.forms.updateEntity so the tests didn't have to change, but for any test that expected the older version, I also made test forms testData.forms.simpleEntity2022 and testData.forms.updateEntity2023 and used those (along with ?ignoreWarnings=true) where appropriate.

I need to take a closer look at how frontend expects warnings. I wrote the nice text "Entities specification version [2023.1.0] is not compatible with Offline Entities. Please use version 2024.1.0 or later.'" in the warning but it's probably not in a place frontend can find it, and we might want to translate it anyway.

What has been done to verify that this works as intended?

Why is this the best possible solution? Were any other approaches considered?

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Does this change require updates to the API documentation? If so, please update docs/api.yaml as part of this PR.

Before submitting this PR, please make sure you have:

• run make test and confirmed all checks still pass OR confirm CircleCI build passes
• verified that any code from external sources are properly credited in comments or that everything is internally sourced

[matthew-white]

I wrote … nice text … in the warning but it's probably not in a place frontend can find it, and we might want to translate it anyway.

I do think that we'll want to translate it. I think we translate other workflow warnings. In general, we want to translate most warnings or errors that a user could trigger by user error. (There's getodk/central#489 to do more of that for errors.)

[matthew-white]

I think it's nice to avoid a let where possible. How about const + a ternary?

const warnings = semverSatisfies(version.get(), '>=2024.1.x')
  ? null
  : {
    type: 'oldEntityVersion',
    // ...
  };

[matthew-white]

The name warnings in the plural makes me think that it should be an array. Just a thought, I also wouldn't mind leaving it as-is until we have a second warning.

[matthew-white]

If you make warnings an array:

Suggested change

	context.transitoryData.get('workflowWarnings').push(dataset.get().warnings);
	context.transitoryData.get('workflowWarnings').push(...dataset.get().warnings);

[matthew-white]

I see that the lines above and below this one use await, but if Forms.checkDatasetWarnings() doesn't need to be async and return a promise, I think it'd be nice to remove the await. I think code is often clearer when things can be done sync.