Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove grey background on "Ready to send" screen #6347

Open
alyblenkin opened this issue Aug 14, 2024 · 4 comments · May be fixed by #6429
Open

Remove grey background on "Ready to send" screen #6347

alyblenkin opened this issue Aug 14, 2024 · 4 comments · May be fixed by #6429
Assignees
Milestone

Comments

@alyblenkin
Copy link
Collaborator

alyblenkin commented Aug 14, 2024

As part of #6320, we want remove the grey banner for "Form last sent" to be consistent with the new styling. Without the app bar elevation / shadow it looks disconnected.

Screenshot 2024-08-19 at 4 31 25 PM

@alyblenkin alyblenkin added this to the v2024.3 milestone Aug 14, 2024
@lognaturel
Copy link
Member

Did you try it as a card by any chance?

@alyblenkin
Copy link
Collaborator Author

@lognaturel Yes, I did try it in a card! It's in the figma link . I was a little hesitant about it last week, but it's not so bad looking at it again.

@grzesiek2010 grzesiek2010 self-assigned this Aug 19, 2024
@lognaturel
Copy link
Member

I don't have a strong feeling either way, it's helpful to see both. It feels like my eyes know where to settle a bit more easily with the card but it's not a big difference.

@alyblenkin
Copy link
Collaborator Author

alyblenkin commented Aug 19, 2024

I think it does anchor the page a bit more! Let's go with the card and we can always drop it if it doesn't' work well with the new app bar.

@grzesiek2010 grzesiek2010 linked a pull request Sep 26, 2024 that will close this issue
6 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
Status: in progress
Development

Successfully merging a pull request may close this issue.

3 participants