Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix import in notebook example #23

Merged
merged 1 commit into from
Dec 13, 2022
Merged

Fix import in notebook example #23

merged 1 commit into from
Dec 13, 2022

Conversation

lognaturel
Copy link
Member

@lognaturel lognaturel commented Nov 1, 2022

Thank you, @Thaliehln!

This specific one is a typo I've made more than once. For better or for worse, both do work so it's likely we'll see both pop up. I think it would be ideal for only pyodk.client to work so examples are consistent but I'm not sure how to achieve that.

EDIT: now I see from @Thaliehln's note that it did /not/ work. What platform are you on, @Thaliehln? I'm wondering whether the behavior I get is related to how macOS treats case for filenames. Regardless, we should be consistent in examples.

@Thaliehln
Copy link

Thaliehln commented Nov 3, 2022

Hi @lognaturel, I am on Microsoft Windows (10.0.18362.1679). I am running Python in Conda environments (conda 4.10.3), including Python 3.8.13 and Python 3.9.7.
If your MacOS is not a case sensitive file system this could indeed explain why the import statement works smoothly on your side while it raises an error on mine (as I have never really used Mac, I am not aware of the specificity of MacOS vs. Windows or Unix).
I agree with you that it is important to have consistent examples, also so that those who are just starting with Python are not stuck at the import step and can start playing with the pyODK package

@yanokwa yanokwa merged commit 1b2c41a into master Dec 13, 2022
@yanokwa yanokwa deleted the fix-import branch December 13, 2022 21:04
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants