Add ability to disable menu bar #911
Conversation
| @@ -39,6 +39,7 @@ Setting name (default value) What doe | |||
| ``DEFAULT_CATEGORY`` will be used as a fallback. | |||
| `DEFAULT_CATEGORY` (``'misc'``) The default category to fall back on. | |||
| `DEFAULT_DATE_FORMAT` (``'%a %d %B %Y'``) The default date format you want to use. | |||
| `DISPLAY_MENU` (``True``) Whether to display menu. | |||
There was a problem hiding this comment.
maybe should you add that to the "notmyidea theme" section instead? Since that's tied to themes / templates, that's not really an option that can be used everywhere (e.g. the themes need to implement it to make it work as intended). It could be good to clarify that in the docs.
There was a problem hiding this comment.
Sure, then we have to do the same for DISPLAY_PAGES_ON_MENU and DISPLAY_CATEGORIES_ON_MENU
|
Hmm. Is customising themes really something that should be done via settings? I thought if you didn't want a menubar you'd just remove it from your template. |
|
@russkel that is true, but having a way to customize the default templates of pelican can become handy |
|
@iElectric any update? |
|
Sorry, don't have the time to update this now, I'll put it on TODO :) |
|
Hi Domen. Would you be so kind as to make the changes @ametaireau mentioned and then rebase and squash your commits? Would be great to get this wrapped up. (^_^) |
|
To better facilitate theme based settings, we should perhaps add a way for themes to provide default settings. This could be done as either a python file in the theme, or perhaps a YAML/ini/JSON file which is applied on-top of the "default" settings but before the user defined settings. |
|
yeah, that sounds like a good option. I believe reusing what sphinx does would be a way to do cool stuff, that is:
|
|
Before I finish this one, the consensus is to move setting to theme settings, along with |
|
@iElectric: My understanding is that is indeed the consensus. (^_^) |
|
Hi Domen. Any update on this topic? |
|
Hey @iElectric. Just looking at the pull request queue and wondering if you might have time to wrap this one up. What do you think? |
|
@justinmayer hey. All good, I'll put it on high priority TODO. |
|
Hi @iElectric. I thought I'd see if you might be willing to help us close out this pull request and get your contribution merged. Do you think that's possible? |
|
@iElectric: If you decide you'd like to continue working on this pull request, please post a comment here and I'll re-open it. |
No description provided.