-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Adds ssl support for prometheus query runner. #6657
Adds ssl support for prometheus query runner. #6657
Conversation
- Adds possibilty to upload and use of ssl cert, key and ca file in redash ui
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6657 +/- ##
==========================================
+ Coverage 62.57% 63.28% +0.71%
==========================================
Files 161 162 +1
Lines 13184 13314 +130
Branches 1797 1817 +20
==========================================
+ Hits 8250 8426 +176
+ Misses 4649 4599 -50
- Partials 285 289 +4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @fabrei, thanks for your PR.
Your update seems to have some points not covered by the unit test. Can you add tests?
- Adds secret attribute to configuration schema.
Hi @masayuki038, I added some tests. Hope it works now with test coverage :) |
Ah, damn the timezone O_o The prometheus query runner does not use any timezone while calculating start and end time. It uses the local timezone on the system. In the CI it is UTC, which differs from my local one. |
- Dynamically calculates timestamps in testcases to be robust in different timezones. - Adds now datetime function to make it more testable.
Now the testcases should be fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fabrei Thanks for your updates! It is very helpful.
Looks good from my end. Please wait for a few days.
@guidopetri @konnectr Could you check this if you have some time?
I am going to merge this since there are no issues. |
* Adds ssl support for prometheus query runner. - Adds possibilty to upload and use of ssl cert, key and ca file in redash ui * Extends test cases for prometheus query runner. - Adds secret attribute to configuration schema. * Fixes wrong timestamps in different timezones in prometheus' testcases. - Dynamically calculates timestamps in testcases to be robust in different timezones. - Adds now datetime function to make it more testable. * Fixes timestamp in prometheus' testcases which can be wrong depending on timezone. --------- Co-authored-by: Masayuki Takahashi <masayuki038@gmail.com>
What type of PR is this?
Description
All versions are compatible.
How is this tested?
Related Tickets & Documents
Asked in discussions to add this feature without issue.
Mobile & Desktop Screenshots/Recordings (if there are UI changes)