removed explicit object inheritance #6686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6686 +/- ##
=======================================
Coverage 63.28% 63.28%
=======================================
Files 162 162
Lines 13313 13313
Branches 1817 1817
=======================================
Hits 8425 8425
Misses 4599 4599
Partials 289 289
|
eradman
requested changes
Jan 4, 2024
There was a problem hiding this comment.
I'm fine with this change. We would also want to add this check to ruff
+++ b/pyproject.toml
@@ -169,7 +169,7 @@ build-backend = "poetry.core.masonry.api"
[tool.ruff]
exclude = [".git", "viz-lib", "node_modules", "migrations"]
ignore = ["E501"]
-select = ["C9", "E", "F", "W", "I001"]
+select = ["C9", "E", "F", "W", "I001", "UP004"]
|
@eradman done |
eradman
approved these changes
Jan 4, 2024
|
@AndrewChubatiuk Thanks for separating the PR. |
|
@eradman Thanks for your review. I didn't find that we should update |
masayuki038
approved these changes
Jan 5, 2024
harveyrendell
pushed a commit
to pushpay/redash
that referenced
this pull request
Jan 8, 2025
* removed explicit object inheritance * minor fix * pr comments --------- Co-authored-by: Andrew Chubatiuk <andrew.chubatiuk@motional.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Removed unneeded explicit inheritance from object