Android: Adds measureActivity test option #23
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
antonis
force-pushed
the
antonis/add-measure-activity
branch
from
602c033 to
5006173
Compare
antonis
commented
Nov 20, 2024
| @@ -220,7 +236,8 @@ class StartupTimeTest : TestBase() { | |||
| } | |||
|
|
|||
| val logEntries = driver.manage().logs().get("logcat") | |||
| val regex = Regex("Displayed ${app.name}/\\.${app.activity}: \\+(?:([0-9]+)s)?([0-9]+)ms") | |||
| val trackedActivity = app.measureActivity ?: app.activity | |||
| val regex = Regex("Displayed ${app.name}/\\.$trackedActivity: \\+(?:([0-9]+)s)?([0-9]+)ms") | |||
There was a problem hiding this comment.
Note that the time (ms) grabbed from the measureActivity is probably just the activity launch time and not the app launch time. The later needs to be calculated or grabbed in another way.
|
Closing for now since this approach did not work getsentry/sentry-react-native#4292 (comment) |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a separate optional test option
measureActivitythat can be used to specify the activity to be tracked for measuring start up time separately from the startupactivity.This is needed on https://github.com/getsentry/sentry-react-native to correctly measure loading time since the main activity of the application is displayed before RN starts executing and thus before the JS SDK inits.
See getsentry/sentry-react-native#4292 for how this intents to be used.