fix: Minor linter issues #520
Open
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vaind
commented
Feb 28, 2024
vaind
commented
- add missing gem cleanup
- autofixed settings.json
Comment on lines
67
to
+72
| && gem install -g --no-document \ | ||
| && gem cleanup all \ |
There was a problem hiding this comment.
just because I'm curious -- what does this do? reading the output it looks like it didn't really uninstall anything:
#16 109.4 Cleaning up installed gems...
#16 109.4 Clean up complete
There was a problem hiding this comment.
guess nothing in this case, it's just what linter said is missing there. To me it sounds like having apt-get clean or apt-get autoremove - you may not need it most of the time but if you do, it's there and no need to come back to the image and investigate whether you can decrease the size.
There was a problem hiding this comment.
some extension in vscode uses these: https://github.com/projectatomic/dockerfile_lint
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.