Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(logger): Update logger to no longer use fstrings #206

Merged
merged 1 commit into from
Jan 14, 2025
Merged

fix(logger): Update logger to no longer use fstrings #206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion devservices/utils/dependencies.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -584,7 +584,7 @@ def _run_command(
cmd: list[str], cwd: str, stdout: int | TextIO | None = subprocess.DEVNULL
) -> None:
logger = logging.getLogger(LOGGER_NAME)
logger.debug(f"Running command: {' '.join(cmd)} in {cwd}")
logger.debug("Running command: %s in %s", " ".join(cmd), cwd)
subprocess.run(cmd, cwd=cwd, check=True, stdout=stdout, stderr=subprocess.DEVNULL)


Expand Down
2 changes: 1 addition & 1 deletion devservices/utils/docker_compose.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ def get_docker_compose_commands_to_run(
def run_cmd(cmd: list[str], env: dict[str, str]) -> subprocess.CompletedProcess[str]:
logger = logging.getLogger(LOGGER_NAME)
try:
logger.debug(f"Running command: {' '.join(cmd)}")
logger.debug("Running command: %s", " ".join(cmd))
return subprocess.run(cmd, check=True, capture_output=True, text=True, env=env)
except subprocess.CalledProcessError as e:
raise DockerComposeError(
Expand Down
Loading