Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore(state): Refactor state to support starting services table #207

Merged

Conversation

hubertdeng123
Copy link
Member

This will allow us to support a starting_services table, allowing us to clean up intermediate states users may get into if devservices up fails. Then, devservices down will clean things up

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.74%. Comparing base (6949f36) to head (f1fcc97).
Report is 5 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #207      +/-   ##
==========================================
+ Coverage   92.67%   92.74%   +0.06%     
==========================================
  Files          22       22              
  Lines        1543     1557      +14     
==========================================
+ Hits         1430     1444      +14     
  Misses        113      113              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

devservices/utils/state.py Outdated Show resolved Hide resolved
devservices/utils/state.py Show resolved Hide resolved
devservices/utils/state.py Show resolved Hide resolved
devservices/utils/state.py Show resolved Hide resolved
devservices/utils/state.py Show resolved Hide resolved
devservices/utils/state.py Show resolved Hide resolved
devservices/utils/state.py Outdated Show resolved Hide resolved
devservices/utils/state.py Outdated Show resolved Hide resolved
devservices/utils/state.py Outdated Show resolved Hide resolved
@IanWoodard IanWoodard merged commit 34f05b2 into main Jan 14, 2025
14 checks passed
@IanWoodard IanWoodard deleted the hubertdeng123/refactor-state-support-starting-services branch January 14, 2025 21:33
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants