Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

Change RecoveryHandler to accept and return http.Handler #106

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tdterry
Copy link

@tdterry tdterry commented Sep 13, 2016

This is a PR for the proposal in #78. It makes RecoveryHandler idiomatic by accepting and returning http.Handler like middleware in other popular libraries. The previous functionality is exposed in the new RecoveryHandlerFunc method.


This change is Reviewable

@jchv
Copy link

jchv commented Dec 2, 2016

I just ran into this problem and would like to voice my support for this breaking change.

If API breaks are a concern, maybe it's time to look into gopkg.

@parkr
Copy link

parkr commented Nov 27, 2017

I'm a huge proponent of having something like this! I wrote a custom wrapper earlier today because I was looking for this. I'd be happy to see NewRecoveryHandler used in order to avoid API breakage.

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants