Skip to content
This repository was archived by the owner on Aug 30, 2023. It is now read-only.

Fix bug: panic not being sent #202

Closed
wants to merge 1 commit into from
Closed

Fix bug: panic not being sent #202

wants to merge 1 commit into from

Conversation

andreiolariu
Copy link

No description provided.

@nvartolomei
Copy link

You can use CapturePanicAndWait if you want to wait for panic to be sent. If you're using Capture directly, then you can wait on the err channel to be closed.

Or, you're relying on PanicHandler which is broken see #194.

@andreiolariu
Copy link
Author

andreiolariu commented Jul 13, 2018

Yes, I am using PanicHandler, but no panics are being sent to the sentry server. I debugged around and found the script ending before it got the chance to make the request. I added that line to wait for it. I guess I should have tried using CapturePanicAndWait instead.

@mattes
Copy link

mattes commented Aug 16, 2018

I believe this PR can be closed.

cc @mattrobenolt

@dcramer dcramer closed this Oct 18, 2018
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants