Skip to content
This repository was archived by the owner on Aug 30, 2023. It is now read-only.

fix cannot convert f #226

Merged
merged 1 commit into from
Jan 5, 2019
Merged

fix cannot convert f #226

merged 1 commit into from
Jan 5, 2019

Conversation

loeffel-io
Copy link
Contributor

@loeffel-io loeffel-io commented Jan 5, 2019 •
edited
Loading

closes #225

@loeffel-io loeffel-io mentioned this pull request Jan 5, 2019
Closed
@mattrobenolt
Copy link
Contributor

Can you link to the changelog or something here? Seems less than ideal if they changed their API like this in a patch release.

@loeffel-io
Copy link
Contributor Author

loeffel-io commented Jan 5, 2019 •
edited
Loading

yea. Should be this release

@daniel-xyz
Copy link

daniel-xyz commented Jan 5, 2019 •
edited
Loading

Changelog: https://github.com/pkg/errors/releases/tag/v0.8.1

More specifically type Frame uintptr has changed to type Frame runtime.Frame

@mattrobenolt
Copy link
Contributor

Well. That’s a lot of changes for a patch release. :(

I’ll merge now in good faith.

@mattrobenolt mattrobenolt merged commit d5057ce into getsentry:master Jan 5, 2019
@loeffel-io loeffel-io deleted the hotfix/convert-f branch January 5, 2019 18:40
@dcramer dcramer mentioned this pull request Jan 7, 2019
Closed
@bfields06 bfields06 mentioned this pull request May 10, 2019
Closed
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

error in stacktrace.go
3 participants
@loeffel-io @mattrobenolt @daniel-xyz