Skip to content
This repository was archived by the owner on Aug 30, 2023. It is now read-only.

add support for github.com/pingcap/errors stacktraces #227

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
add support for github.com/pingcap/errors stacktraces
  • Loading branch information
Josh Leverette committed Jan 8, 2019
commit fd090ae0a4cac3f5feffbb9fe6dfe859bf342cd1
81 changes: 56 additions & 25 deletions stacktrace.go
Original file line number Diff line number Diff line change
@@ -14,6 +14,7 @@ import (
"strings"
"sync"

pingcap "github.com/pingcap/errors"
"github.com/pkg/errors"
)

@@ -51,32 +52,62 @@ type StacktraceFrame struct {
InApp bool `json:"in_app"`
}

// Try to get stacktrace from err as an interface of github.com/pkg/errors, or else NewStacktrace()
func GetOrNewStacktrace(err error, skip int, context int, appPackagePrefixes []string) *Stacktrace {
stacktracer, errHasStacktrace := err.(interface {
StackTrace() errors.StackTrace
})
if errHasStacktrace {
var frames []*StacktraceFrame
for f := range stacktracer.StackTrace() {
pc := uintptr(f) - 1
fn := runtime.FuncForPC(pc)
var fName string
var file string
var line int
if fn != nil {
file, line = fn.FileLine(pc)
fName = fn.Name()
} else {
file = "unknown"
fName = "unknown"
}
frame := NewStacktraceFrame(pc, fName, file, line, context, appPackagePrefixes)
if frame != nil {
frames = append([]*StacktraceFrame{frame}, frames...)
}
type pkgStacktracer interface {
StackTrace() errors.StackTrace
}

func pkgStacktrace(stacktracer pkgStacktracer, context int, appPackagePrefixes []string) *Stacktrace {
var frames []*StacktraceFrame
for f := range stacktracer.StackTrace() {
pc := uintptr(f) - 1
fn := runtime.FuncForPC(pc)
var fName string
var file string
var line int
if fn != nil {
file, line = fn.FileLine(pc)
fName = fn.Name()
} else {
file = "unknown"
fName = "unknown"
}
frame := NewStacktraceFrame(pc, fName, file, line, context, appPackagePrefixes)
if frame != nil {
frames = append([]*StacktraceFrame{frame}, frames...)
}
}
return &Stacktrace{Frames: frames}
}

func pingcapStacktrace(stacktracer pingcap.StackTracer, context int, appPackagePrefixes []string) *Stacktrace {
var frames []*StacktraceFrame
for f := range stacktracer.StackTrace() {
pc := uintptr(f) - 1
fn := runtime.FuncForPC(pc)
var fName string
var file string
var line int
if fn != nil {
file, line = fn.FileLine(pc)
fName = fn.Name()
} else {
file = "unknown"
fName = "unknown"
}
frame := NewStacktraceFrame(pc, fName, file, line, context, appPackagePrefixes)
if frame != nil {
frames = append([]*StacktraceFrame{frame}, frames...)
}
return &Stacktrace{Frames: frames}
}
return &Stacktrace{Frames: frames}
}

// Try to get stacktrace from err as an interface of github.com/pkg/errors or github.com/pingcap/errors, or else NewStacktrace()
func GetOrNewStacktrace(err error, skip int, context int, appPackagePrefixes []string) *Stacktrace {
if stacktracer, errHasStacktrace := err.(pkgStacktracer); errHasStacktrace {
return pkgStacktrace(stacktracer, context, appPackagePrefixes)
} else if stacktracer, errHasStacktrace := err.(pingcap.StackTracer); errHasStacktrace {
return pingcapStacktrace(stacktracer, context, appPackagePrefixes)
} else {
return NewStacktrace(skip+1, context, appPackagePrefixes)
}