fix(server): Assign a default name for unnamed attachments (#769)

Assigns a fallback name of "Unnamed Attachment" if an attachment envelope item
is ingested without a `filename` header. This can be considered a non-fatal
implementation error in SDKs.

CHANGELOG.md

@@ -26,6 +26,7 @@
 - Add a standalone tool to document metrics in JSON or YAML. ([#752](https://github.com/getsentry/relay/pull/752))
 - Emit `processing.event.produced` for user report and session Kafka messages. ([#757](https://github.com/getsentry/relay/pull/757))
 - Improve performance of event processing by avoiding regex clone. ([#767](https://github.com/getsentry/relay/pull/767))
+- Assign a default name for unnamed attachments, which prevented attachments from being stored in Sentry. ([#769](https://github.com/getsentry/relay/pull/769))
 
 ## 20.8.0
 

relay-server/src/actors/store.rs

@@ -28,6 +28,9 @@ lazy_static::lazy_static! {
         Uuid::new_v5(&Uuid::NAMESPACE_URL, b"https://sentry.io/#did");
 }
 
+/// Fallback name used for attachment items without a `filename` header.
+const UNNAMED_ATTACHMENT: &str = "Unnamed Attachment";
+
 #[derive(Fail, Debug)]
 pub enum StoreError {
     #[fail(display = "failed to send kafka message")]
@@ -117,7 +120,10 @@ impl StoreForwarder {
 
         Ok(ChunkedAttachment {
             id,
-            name: item.filename().map(str::to_owned),
+            name: match item.filename() {
+                Some(name) => name.to_owned(),
+                None => UNNAMED_ATTACHMENT.to_owned(),
+            },
             content_type: item
                 .content_type()
                 .map(|content_type| content_type.as_str().to_owned()),
@@ -214,8 +220,8 @@ struct ChunkedAttachment {
     /// The triple `(project_id, event_id, id)` identifies an attachment uniquely.
     id: String,
 
-    /// File name of the attachment file. Should not be `None`.
-    name: Option<String>,
+    /// File name of the attachment file.
+    name: String,
 
     /// Content type of the attachment payload.
     content_type: Option<String>,