fix(server): Enforce size limits on UE4 crash reports [ISSUE-1315] #1099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-auer
changed the title
jjbayer
approved these changes
Oct 7, 2021
jan-auer
force-pushed
the
fix/ue4-size-limits
branch
from
c2a5003
to
0c5c70e
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UE4 crash reports are compressed archives that are unpacked during ingestion in Relay. After expansion, the size of the resulting envelope and its file attachments was never checked, which could pass attachments far exceeding the maximum size limits.
Note that the current implementation drops the entire envelope if even a single attachment file exceeds the file size limit. I went with this approach because it is consistent to how the store endpoint behaves, reusing the same function. We may want to reconsider this, since in UE4 this is usually log files, which only have marginal value compared to the actual crash report. I suggest tackling this in a follow-up.