Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(metrics): Add more statsd metrics for relay metric bucketing [INGEST-637] #1124

Merged
merged 3 commits into from
Nov 16, 2021

Conversation

untitaker
Copy link
Member

Add more statsd metrics for measuring our own metrics bucketing. We're
investigating bucketing efficiency at the moment, but this is generally
good to have.

Add more statsd metrics for measuring our own metrics bucketing. We're
investigating bucketing efficiency at the moment, but this is generally
good to have.
@untitaker untitaker requested a review from a team November 15, 2021 15:42
Copy link
Member

@jjbayer jjbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering if we need an InsertBuckets counter as well, but I guess it can be derived:

InsertBuckets = (MergeHit + MergeMiss) - InsertMetrics

@untitaker
Copy link
Member Author

I was wondering if we need an InsertBuckets counter as well

I didn't think about it before but I don't think we need this metric right now either.

@untitaker untitaker enabled auto-merge (squash) November 16, 2021 10:10
@untitaker untitaker merged commit 8b3cf4d into master Nov 16, 2021
@untitaker untitaker deleted the fix/more-metric-metrics branch November 16, 2021 10:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants