-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
ref(metrics): Add custom and more builtin units [INGEST-939] #1217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-auer
commented
Mar 31, 2022
jan-auer
changed the title
ref(metrics): Add custom and more builtin units
ref(metrics): Add custom and more builtin units [INGEST-939]
Mar 31, 2022
gave it a sweep and lgtm overall! |
Correct, we'll have to add them to the event schema. |
jjbayer
approved these changes
Apr 7, 2022
jan-auer
force-pushed
the
ref/metric-units
branch
from
April 7, 2022 17:46
229104a
to
ac04b2f
Compare
ahmedetefy
approved these changes
Apr 7, 2022
2 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a number of grouped builtin units and a "custom unit" variant.
Builtin Unit Groups
Units within the same group are considered convertible. Each group has a default canonical unit, for instance
byte
for information units. In the future, Relay can streamline incoming metrics by converting to the canonical unit within the respective group. The currently defined builtin units are:nanosecond
/microsecond
/millisecond
/second
/minute
/hour
/day
/week
bit
/byte
/kibibyte
/mebibyte
/gibibyte
/tebibyte
/pebibyte
/exbibyte
percent
/ratio
none
,""
(used for: counts)Custom Units
For forward compatibility, clients can send custom unit names of up to 15 ASCII characters. Beyond ASCII lowercasing, these units do not count as convertible. An example for such a unit would be
frame
to track the frame rate of a user interface or game.Follow-Ups
Notes
Based on #1215, will be rebased once merged.
cc @sl0thentr0py