fix(metrics): Consistent transaction.status [INGEST-1416] #1333
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In store normalization, we set
contexts.trace.status
to unknown in case it is missing from the trace context.In metrics extraction, which runs before normalization, we simply ignored a missing status. Align.
..., status=none
will now move to bucket..., status=unknown
.unknown
in the indexer, so this will not increase indexer storage.Future Work
To reduce code duplication, carve out the parts of store normalization that are needed for metrics extraction and put it something like a
PreMetricsProcessor
that runs before extraction.